Skip to content

Add Hex package configuration and display "Find on Hex" footer links #1385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wojtekmach merged 2 commits into from
Aug 12, 2021
Merged

Add Hex package configuration and display "Find on Hex" footer links #1385

wojtekmach merged 2 commits into from
Aug 12, 2021

Conversation

@wojtekmach
Copy link
Member

@wojtekmach wojtekmach commented Aug 12, 2021 •
edited
Loading

Demo:

Screen.Recording.2021-08-12.at.11.57.42.mov

Future work: (out of the scope of this PR)

  1. Support Hex diff. Currently when linking to Hex diff, we need to include two versions to diff against. It would be nice to be able to provide just a single version, e.g.: https://diff.hex.pm/diff/decimal/2.0.0, and Hex diff would automatically pick the version immediately preceding that.
  2. Support Hex private packages. We can already do that for packages themselves but let's wait for private packages support in Preview (Support Hex private packages hexpm/preview#48) and possibly Diff (Support Hex private packages hexpm/diff#74)

@wojtekmach
Copy link
Member Author

wojtekmach commented Aug 12, 2021

@ericmj in the pr description I mentioned future work, any feedback on that in particular would be appreciated :)

@ericmj
Copy link
Member

ericmj commented Aug 12, 2021

  1. Sounds good, please open an issue for that.
  2. That is on the roadmap but currently low priority personally.

@wojtekmach
Copy link
Member Author

wojtekmach commented Aug 12, 2021

Created hexpm/diff#75 for number 1, thanks for the feedback!

@wojtekmach wojtekmach merged commit aa1afb2 into master Aug 12, 2021
@wojtekmach wojtekmach deleted the wm-find-on-hex branch August 12, 2021 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wojtekmach @ericmj